Add type checking #69
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 86.26% 86.26%
=======================================
Files 20 20
Lines 1303 1354 +51
=======================================
+ Hits 1124 1168 +44
- Misses 179 186 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will improve performance by 15.17%
Performance Changes
Comparing 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68
I've chosen to use
pyrightbecause it appears to be the current most advanced type checking tool available for Python. I've set this project to usestricttype checking, but other settings arebasicandstandard. For most other Dissect projects, I think we should just start out withbasicand incrementally increase it.The side-effect of type checking in the
lintstep are that we now must also install dependencies in order to check types with that.I've given it my best shot to make
dissect.utiladhere to thestrictruleset.